Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark and speed up to first stage of binning. #385

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

First stage of binning process reads all partial histogram files and combines them into a single histogram. This was initially written to combine the histograms as sparse arrays, but this can be very expensive, so just flatten out the arrays as we're combining them.

NB: I've added benchmarks with copier, so this also updates the copier version and other associated changes.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (c61c1a7) to head (2cad92a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          26       26           
  Lines        1507     1519   +12     
=======================================
+ Hits         1503     1515   +12     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it show the first benchmark results only after you merge it? Have you run it on your laptop?

@delucchi-cmu delucchi-cmu merged commit 827aac0 into main Sep 12, 2024
11 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/slow_binning branch September 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants