Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading a file to pyarrow table in catalog import #415

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

This is related to issue #351, but does not close it.

Allows the InputReader read method to return a pyarrow Table, instead of a Pandas dataframe. Pandas dataframes are converted to pyarrow tables, and all manipulation after that point is based on pyarrow operations.

This means that tables generated will NOT have the _healpix_29 field set as the pandas index.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.88%. Comparing base (aeb92ae) to head (2572e14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats_import/index/map_reduce.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   99.00%   98.88%   -0.13%     
==========================================
  Files          29       29              
  Lines        1609     1612       +3     
==========================================
+ Hits         1593     1594       +1     
- Misses         16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [aeb92ae] After [6ae8c36] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit bdee662 into main Oct 21, 2024
9 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/351/parquet branch October 21, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants