Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of expected number of margin rows written. #418

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Closes #258.

As a bonus, we can track the number of rows that are expected from the mapping stage, and we can double-check total after reducing stage.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.63%. Comparing base (f455690) to head (d302ade).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ts_import/margin_cache/margin_cache_resume_plan.py 88.88% 2 Missing ⚠️
src/hats_import/margin_cache/margin_cache.py 85.71% 1 Missing ⚠️
src/hats_import/pipeline_resume_plan.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   98.85%   98.63%   -0.23%     
==========================================
  Files          28       28              
  Lines        1576     1615      +39     
==========================================
+ Hits         1558     1593      +35     
- Misses         18       22       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 22, 2024

Before [f455690] After [2ef70e3] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tiny stylistic comments only.

src/hats_import/margin_cache/margin_cache_resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/pipeline_resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/pipeline_resume_plan.py Outdated Show resolved Hide resolved
src/hats_import/margin_cache/margin_cache.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 4956672 into main Oct 23, 2024
8 of 10 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/258/empty branch October 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error behavior if margin generation results in empty catalog
2 participants