-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of expected number of margin rows written. #418
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 98.85% 98.63% -0.23%
==========================================
Files 28 28
Lines 1576 1615 +39
==========================================
+ Hits 1558 1593 +35
- Misses 18 22 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tiny stylistic comments only.
Co-authored-by: Derek T. Jones <[email protected]>
Closes #258.
As a bonus, we can track the number of rows that are expected from the mapping stage, and we can double-check total after reducing stage.