Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification tests #428

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add verification tests #428

wants to merge 4 commits into from

Conversation

troyraen
Copy link
Collaborator

@troyraen troyraen commented Nov 5, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Closes #118, closes #373, closes #374

Adds the following:

  • Verifier class
    • verification tests: hipscat is_valid_catalog, schemas, file sets, row counts
    • output files: verifier_results.csv
  • Test data
    • datasets: bad_schemas, wrong_files_and_rows
  • Unit tests

Stil to-do:

  • Test a large catalog and determine whether tests may benefit from parallelization with dask.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

github-actions bot commented Nov 5, 2024

Before [57aaa9d] After [0e37cc0] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@troyraen troyraen mentioned this pull request Nov 5, 2024
14 tasks
@troyraen
Copy link
Collaborator Author

troyraen commented Nov 5, 2024

Unit tests are failing because of #427.

I need some guidance on the pre-commit failures. Most seem to be a result of path arguments being accepted as strings which are converted in the post_init, but the conversion isn't being recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant