Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write point map with cdshealpix skymap #409

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

camposandro
Copy link
Contributor

Migrate the point_map.fits I/O operations to use cdshealpix skymap methods. Closes #399.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (8e1d456) to head (37f3b9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   92.69%   92.89%   +0.19%     
==========================================
  Files          49       49              
  Lines        2095     2096       +1     
==========================================
+ Hits         1942     1947       +5     
+ Misses        153      149       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hats/io/file_io/file_io.py Outdated Show resolved Hide resolved
src/hats/io/file_io/file_io.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 1, 2024

Before [8e1d456] After [c35593e] Ratio Benchmark (Parameter)
13.9±0.9ms 15.0±1ms 1.08 benchmarks.Suite.time_inner_pixel_alignment
1.01±0.03ms 1.05±0.03ms 1.04 benchmarks.time_test_cone_filter_multiple_order
110±1ms 112±1ms 1.02 benchmarks.Suite.time_paths_creation
94.3±0.5ms 94.4±0.7ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
387±0.9ms 387±3ms 1 benchmarks.Suite.time_outer_pixel_alignment
23.0±0.3ms 22.9±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
46.3±0.4ms 45.8±0.2ms 0.99 benchmarks.Suite.time_pixel_tree_creation
125±0.6ms 124±0.3ms 0.99 benchmarks.time_test_alignment_even_sky
95.5±0.3ms 93.9±0.8ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7

Click here to view all benchmarks.

@camposandro camposandro merged commit bccf40c into main Nov 1, 2024
11 checks passed
@camposandro camposandro deleted the issue/399/migrate-skymap-io branch November 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read/write fits files with cds-healpix methods
2 participants