Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address smoke test failures from missing argument. #24

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Address smoke test failures from missing argument. #24

merged 1 commit into from
Apr 22, 2024

Conversation

delucchi-cmu
Copy link
Contributor

The overwrite argument was removed in astronomy-commons/hipscat-import#280

@github-actions GitHub Actions
Copy link

Before [d417cb6] After [2bc0314] Ratio Benchmark (Parameter)
1.21±0.8s 3.83±0.3s ~3.18 benchmarks.time_computation
496 1.4k 2.82 benchmarks.mem_list

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested review from jeremykubica and hombit and removed request for jeremykubica April 22, 2024 15:57
@delucchi-cmu delucchi-cmu merged commit fe8ad8d into main Apr 22, 2024
7 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch April 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hombit hombit hombit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @hombit