Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address now-missing argument in crossmatch #27

Merged
merged 1 commit into from
May 2, 2024
Merged

Address now-missing argument in crossmatch #27

merged 1 commit into from
May 2, 2024

Conversation

delucchi-cmu
Copy link
Contributor

PR astronomy-commons/lsdb#301 removed general kwargs from cross match methods.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Before [7bf2d94] After [9b5c6e2] Ratio Benchmark (Parameter)
1.71±0.8s 2.71±1s ~1.59 benchmarks.time_computation
1.57k 1.42k 0.90 benchmarks.mem_list

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from hombit May 2, 2024 17:30
@delucchi-cmu delucchi-cmu merged commit 8dbd116 into main May 2, 2024
7 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch May 2, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hombit hombit hombit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @hombit