Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update radius as default has changed. #6

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Units and distance on default cross match radius changed in astronomy-commons/lsdb#134

This resulted in smoke failures, and this PR sets the radius to the old default value (0.01 degrees).

Also fixes smoke test badge link on readme.

Copy link

Before [4c7518b] After [0b9697e] Ratio Benchmark (Parameter)
3.19±0.6s 1.75±0.9s ~0.55 benchmarks.time_computation
2.82k 4.14k 1.46 benchmarks.mem_list

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 712947b into main Jan 31, 2024
8 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch January 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants