Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address smoke test failure #8

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Address smoke test failure #8

merged 1 commit into from
Feb 23, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Changes in astronomy-commons/hipscat-import#234 caused the hipscat-import tests to fail.

This also addresses some warnings that have been introduced recently.

@github-actions GitHub Actions
Copy link

Before [366b441] After [bee94e7] Ratio Benchmark (Parameter)
3.05±0.8s 1.68±0.5s ~0.55 benchmarks.time_computation
912 536 0.59 benchmarks.mem_list

Click here to view all benchmarks.

camposandro
camposandro approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit ee9f120 into main Feb 23, 2024
8 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch February 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camposandro camposandro camposandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @camposandro