Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable std tqdm bar, refactor for re-use. #330

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #327.

Consolidates all tqdm calls into re-used print_progress method. This way, the simple_progress_bar argument will work the same for all pipeline types.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (c5e6095) to head (1899993).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   99.56%   99.78%   +0.21%     
==========================================
  Files          26       26              
  Lines        1379     1389      +10     
==========================================
+ Hits         1373     1386      +13     
+ Misses          6        3       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit
Copy link
Contributor

hombit commented Jun 5, 2024

Should tqdm be also removed from the dependencies?

@delucchi-cmu
Copy link
Contributor Author

Should tqdm be also removed from the dependencies?

No - we're still using the package, but we use different imports for different behavior (std out vs widget). The imports are still present in pipeline_resume_plan.py.

@delucchi-cmu delucchi-cmu requested a review from hombit June 6, 2024 15:17
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great, thanks! Could you please mention this new option in the docs?

@delucchi-cmu delucchi-cmu merged commit 22cba75 into main Jun 12, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/327/tqdm branch June 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bars are missing in my Jupyter environment (PSC)
2 participants