Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update margin cache catalog info parameters #332

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

camposandro
Copy link
Collaborator

Adds the catalog specific metadata ("epoch", "ra" and "dec") to the margin catalog info output. Closes #331.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Jun 6, 2024
@camposandro camposandro changed the title Update margin cache info output Update margin cache catalog info parameters Jun 6, 2024
@camposandro camposandro marked this pull request as ready for review June 6, 2024 18:43
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (3b2c3ae) to head (87ecd85).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          26       26           
  Lines        1389     1389           
=======================================
  Hits         1386     1386           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camposandro camposandro merged commit 3bcec06 into main Jun 6, 2024
9 checks passed
@camposandro camposandro deleted the update-margin-cache-info branch June 6, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add primary catalog ra/dec to margin catalog info.
2 participants