Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary directory when all intermediate files are deleted #382

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

camposandro
Copy link
Collaborator

If the user provides a temporary directory that was created outside of the output directory, and all intermediate parquet / resume log files have been deleted at the end of the pipeline, remove that same directory. Closes #298.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (d87041a) to head (42a9877).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          26       26           
  Lines        1496     1507   +11     
=======================================
+ Hits         1492     1503   +11     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docstring comment. Otherwise LGTM.

src/hipscat_import/pipeline_resume_plan.py Outdated Show resolved Hide resolved
@camposandro camposandro merged commit c61c1a7 into main Aug 26, 2024
10 checks passed
@camposandro camposandro deleted the issue/298/erase-empty-temp-dir branch August 26, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog import leaves an empty directory behind
2 participants