-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FilePointer with universal pathlib #413
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 44 44
Lines 1545 1547 +2
=======================================
+ Hits 1512 1514 +2
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
Documentation issue will require astronomy-commons/hats-import#387, but I'd like to send for review for general comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soo nice to be getting rid of storage options from everywhere
See astronomy-commons/hats#336
Solution Description
Use fsspec's project, universal-pathlib as a path provider. In this way, everywhere we currently pass in a
FilePointer
we can use aPath
instead, and when we need to create remote connections, useUPath
.