-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap nested_dask reduce
#414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I have one question that I would not consider a blocker and more just curiosity.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #414 +/- ##
===============================================
- Coverage 97.94% 97.92% -0.03%
===============================================
Files 44 44
Lines 1560 1591 +31
===============================================
+ Hits 1528 1558 +30
- Misses 32 33 +1 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
d56acc2
to
9109678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool, thanks! I'd ask for a bit more testing if it wouldn't take a lot of time
9ea6cd2
to
783ed13
Compare
Adds the
reduce
function to theCatalog
class, wrapping thereduce
function innd.NestedFrame
Fixes #420 and fixes #372