Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes Task/03 #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Completes Task/03 #37

wants to merge 9 commits into from

Conversation

bretthandrews
Copy link
Collaborator

No description provided.

yymao
yymao requested changes Oct 16, 2018
View reviewed changes
Copy link
Collaborator

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 💯!

task-03/get_top_names.py Show resolved Hide resolved
task-03/get_top_names.py Outdated Show resolved Hide resolved
task-03/get_top_names.py Outdated Show resolved Hide resolved
@bretthandrews
Copy link
Collaborator Author

Thanks for the feedback!

@yymao
Copy link
Collaborator

yymao commented Oct 16, 2018

Ah I didn't catch that. But now the include_start option won't work. You can use continue to achieve this functionality.

yymao
yymao requested changes Oct 16, 2018
View reviewed changes
Copy link
Collaborator

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make include_start option work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yymao yymao yymao requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bretthandrews @yymao