Test PR #298
Closed
Test PR #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
gwcs_test_dep
branch
from
154934b to
8444e3a
Compare
Cadair
reviewed
Sep 10, 2025
tox.ini
Outdated
| devdeps: pip install -U --pre -i https://pypi.anaconda.org/astropy/simple astropy | ||
|
|
||
| # gwcs is incompatible with our oldest deps | ||
| oldestdeps: pip uninstall gwcs |
There was a problem hiding this comment.
This means I need to make gwcs optional in the tests again. Which I can, I don't mind 🤷
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 99.39% 99.45% +0.05%
==========================================
Files 64 67 +3
Lines 2325 2373 +48
==========================================
+ Hits 2311 2360 +49
+ Misses 14 13 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
braingram
force-pushed
the
gwcs_test_dep
branch
from
8444e3a to
20279d6
Compare
braingram
force-pushed
the
gwcs_test_dep
branch
from
20279d6 to
8c0dcd6
Compare
Cadair
reviewed
Sep 10, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def wrapped_wcses(all_4d_wcses): |
There was a problem hiding this comment.
I'm kinda keen to test gwcs inputs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing an option for adding gwcs as a test dependency for #296