APE 1: Number is gone once reserved (naming chaos fix 2) #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Asking people to put a number in APE proposal filename too early and then changing the number last minute can cause merge conflict (for another open APE proposal) and confusion (for everyone else).
Case study:
But why are we renaming? To prevent gaps in accepted APE listing (e.g., the still open #14 and the missing APE 11 in the list of accepted APEs).
But are gaps really a big deal? In PEP (Python), they don't do re-numbering. And maybe neither in NEP (NumPy).
Proposed solution: As long as APE author follows the rules and use the next available number properly, the number is considered taken and cannot be reused. If the proposal is rejected, it either appears as a gap in the README or CoCo can say that APE number was rejected. Exception can be made to re-use a number if the proposal PR is closed as invalid/spam. If APE author uses an invalid number, reviewer would point that out very early in the review process (I think that is already status quo at the time of writing this PR).
Pros: No more numbering confusion.
Cons: Might end up with a lot of gaps in the listing of accepted APEs. For example, people will keep wondering what happened to APE 11 like we do with Windows 9.
Alternative:
More discussion: https://groups.google.com/g/astropy-dev/c/7Tnx7S3aGP4