Changelog to auto skip when no code change of interest detected #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
+ Coverage 98.61% 98.81% +0.2%
=========================================
Files 3 3
Lines 144 169 +25
=========================================
+ Hits 142 167 +25
Misses 2 2
Continue to review full report at Codecov.
|
| ('Affects-dev' not in pr_handler.labels)): | ||
| statuses['changelog'] = {'description': 'Changelog not required for these changes', | ||
| 'state': 'success'} | ||
| return statuses |
There was a problem hiding this comment.
Some of this logic is a bit too specific to the core package (the bot can be used on any other packages). It's also not 100% clear to me that files outside of astropy and cextern never require a changelog entry (e.g. setup.cfg). I'd suggest therefore just limiting has_code_change to just checking that the files aren't all tests?
There was a problem hiding this comment.
Wait, now I am confused. I thought core-specific stuff goes here and generic stuff goes to baldrick? Where is core-specific stuff supposed to go, then?
There was a problem hiding this comment.
Just to clarify, the stuff here is specific to the astropy project, not just the core package - so for example we use it for astropy-helpers too.
There was a problem hiding this comment.
Oh... 🤔 Any idea where to put core specific stuff? I was gonna expand it to auto add subpackage labels next and that is very core specific.
There was a problem hiding this comment.
Then what is baldrick for? SunPy is part of the Astropy project too, right, since it is affiliated? (I am just confused, not disagreeing.)
There was a problem hiding this comment.
I will have to think about this... Making this too generic might also render it pretty much useless. One of the original request was to auto add the label if only doc change is detected. To detect doc change in a more generic way is more complicated, so that is why I did it this way for shorter if checks. 🤔 🤔 🤔
This address OpenAstronomy/baldrick#64 but in ways that is specific to astropy core repo.
🎉 100 🎉