Make Numpy loop function args const correct #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 6 6
Lines 503 503
=======================================
Hits 444 444
Misses 59 59 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
pllim
reviewed
Nov 13, 2023
dstansby
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
I applied this as a patch over at conda-forge, and it fixed the failed builds on macOS: conda-forge/astropy-healpix-feedstock@6510203
astrofrog
approved these changes
Nov 18, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See numpy/numpy#15355.
CC @dstansby.