Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax for installing from git repos to latest recommended #12

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update syntax for installing from git repos to latest recommended #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d68418
Update syntax for installing from git repos to latest recommended, wh…
astrofrog Nov 10, 2023
692c974
Run in PRs
astrofrog Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration_testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: astropy_rc_basic

on:
workflow_dispatch:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no security concern, I guess it is okay to leave this in? This is a low-traffic repo anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any potential security concerns with this. And any PR is likely to change the config in a way we want to make sure it isn't breaking I think.


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -27,5 +28,4 @@ jobs:
- linux: py311-reproject
- linux: py311-specreduce
- linux: py311-specutils
# FIXME: Chained dependencies in sunpy/setup.cfg not working here.
#- linux: py311-sunpy
- linux: py311-sunpy
22 changes: 11 additions & 11 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ pip_pre = true
# side effects and make sure all test suites pass with all packages
deps =
astropy[all,test]
asdf_astropy,all: git+https://github.com/astropy/asdf-astropy.git#egg=asdf_astropy[test]
astropy_healpix,all: git+https://github.com/astropy/astropy-healpix.git#egg=astropy_healpix[test]
astroquery,all: git+https://github.com/astropy/astroquery.git#egg=astroquery[test,all]
asdf_astropy,all: asdf_astropy[test] @ git+https://github.com/astropy/asdf-astropy.git
astropy_healpix,all: astropy_healpix[test] @ git+https://github.com/astropy/astropy-healpix.git
astroquery,all: astroquery[test,all] @ git+https://github.com/astropy/astroquery.git
ccdproc,all: psutil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops did I use the wrong syntax to pull in dependencies? My bad!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this original syntax did work at some point but I think it's not the latest and maybe doesn't work with new features like what sunpy uses. In any case, this should now be the preferred syntax.

ccdproc,all: git+https://github.com/astropy/ccdproc.git#egg=ccdproc[test,all]
photutils,all: git+https://github.com/astropy/photutils.git#egg=photutils[test,all]
regions,all: git+https://github.com/astropy/regions.git#egg=regions[test,all]
reproject,all: git+https://github.com/astropy/reproject.git#egg=reproject[test,all]
specreduce,all: git+https://github.com/astropy/specreduce.git#egg=specreduce[test]
specutils,all: git+https://github.com/astropy/specutils.git#egg=specutils[all,test]
sunpy,all: git+https://github.com/sunpy/sunpy.git#egg=sunpy[tests,all]
ccdproc,all: ccdproc[test,all] @ git+https://github.com/astropy/ccdproc.git
photutils,all: photutils[test,all] @ git+https://github.com/astropy/photutils.git
regions,all: regions[test,all] @ git+https://github.com/astropy/regions.git
reproject,all: reproject[test,all] @ git+https://github.com/astropy/reproject.git
specreduce,all: specreduce[test] @ git+https://github.com/astropy/specreduce.git
specutils,all: specutils[all,test] @ git+https://github.com/astropy/specutils.git#egg=
sunpy,all: sunpy[tests,all] @ git+https://github.com/sunpy/sunpy.git

skip_install = true

Expand All @@ -49,4 +49,4 @@ commands =
reproject,all: pytest --pyargs reproject
specreduce,all: pytest --pyargs specreduce
specutils,all: pytest --pyargs specutils
sunpy,all: pytest --pyargs sunpy
sunpy,all: pytest --pyargs sunpy --doctest-ignore-import-errors
Loading