Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Affiliated Editors' role descriptions to include their future tasks under the pyOpenSci partnership #574

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Update Affiliated Editors' role descriptions to include their future tasks under the pyOpenSci partnership #574

merged 2 commits into from
Feb 29, 2024

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Feb 15, 2024 •
edited
Loading

Part of the transition of our Affiliated Package Review process into partnership with pyOpenSci

Fixing #569

pllim
pllim reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content is good, except for a typo.

Would be nice if @hamogu and @lwasser could have a look through. Thanks!

roles.json Outdated Show resolved Hide resolved
@dhomeier dhomeier mentioned this pull request Feb 15, 2024
Merged
pllim
pllim approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better than the version I came up with over at #573 .

When should we merge this?

@dhomeier dhomeier marked this pull request as ready for review February 17, 2024 00:03
pllim
pllim approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already started the transition here and there, and it has been 2 weeks with multiple approvals and no objection, so I am merging. Thanks!

@pllim pllim merged commit 41e5ae1 into astropy:main Feb 29, 2024
1 check passed
@pllim pllim mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceb8 ceb8 ceb8 approved these changes

@pllim pllim pllim approved these changes

@hamogu hamogu hamogu approved these changes

Assignees
No one assigned
Labels
affiliated-packages roles and team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhomeier @hamogu @pllim @ceb8