-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-APE 22 listing #590
Post-APE 22 listing #590
Conversation
Co-authored-by: Tom Donaldson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tsk tsk... indentation looked fine locally. Maybe there are tabs in there messing things up.
affiliated/index.html
Outdated
nmcell.setAttribute('width', 100) | ||
urlcell.innerHTML = url_translator(package["gh_meta"]["documentation"]); | ||
repocell.innerHTML = repo_translator(package["repository_link"]); | ||
//pypicell.innerHTML = pypi_translator(package["pypi_name"]); // FIXME: Not found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lwasser on "pypi_name" and also status of pyOpenSci/software-peer-review#268 for cross-listing. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed "pypi_name" with Leah "offline" and I opened pyOpenSci/pyopensci.github.io#390 as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pllim did you get this working? is that page pulling from our yaml file now? if so that is amazing. The next few weeks for me are fairly busy with a few work meetings (including scipy!). but i suspect we can get someone to work on this during our scipy sprint - will anyone from astropy be at SciPy in Tacoma by chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see output here: https://www.astropy.org/affiliated/#affiliated-package-list 😸
will anyone from astropy be at SciPy in Tacoma by chance?
I am not sure. I will ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm by no means a js or website expert, but I don't spot anything bad and the output looks fine. So, I'm approving and I suggest to take this - we can improve more later if needed.
However, I'm not merging yet, to give others the chance to have a look.
but bundle it for use in a client. So I created yaml_parse.js | ||
|
||
import parse from 'yaml' | ||
window.yaml = parse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I'll note here is that I'm sure forcing it onto window
isn't the standard way to make the this yaml
available, but I ran out of time learning the right way, and it should work.
and make GH username a link for maintainer full name.
Given there is approval and it works, I am just going to merge. Any improvement can be follow-up PR(s). Thanks! |
and add a generic link back to pyOpenSci
Fix #579
Many thanks to @tomdonaldson for the JS and instructions and examples on how to use it!
Rendered page: https://output.circle-artifacts.com/output/job/52dd5ca9-0435-4e1c-8935-07de7741b452/artifacts/0/html/affiliated/index.html#affiliated-package-list