Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise internal error for nonexistent subpackages #17

Closed
wants to merge 1 commit into from

Conversation

MridulS
Copy link

@MridulS MridulS commented Feb 20, 2024

A hacky fix for #9, not sure if this the best way. Maybe it's okay to just keep it as it is? pytest seems to consider zero collected tests also as a special case, https://docs.pytest.org/en/stable/reference/exit-codes.html

Fixes #9

@bsipocz bsipocz added the bug Something isn't working label Feb 23, 2024
@pllim
Copy link
Member

pllim commented Mar 4, 2024

The failing CI isn't a good sign.

I actually think "0 test collected" (current behavior without this PR) is reasonable, so personally I don't think #9 is critical to address, but maybe @bsipocz feels otherwise still.

@MridulS
Copy link
Author

MridulS commented Mar 17, 2024

Ah yeah, this only seems to works with pytest > 8.

I agree maybe it's just fine to keep the current behavior? (Especially because I don't really like the solution I proposed 😅 )

@pllim pllim closed this Mar 18, 2024
@pllim
Copy link
Member

pllim commented Mar 18, 2024

Thanks for trying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: -P nonexistentmodule should fail
3 participants