Fix for issue #240 #243
Merged
Fix for issue #240 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spectrum contained an all-nan column.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 85.38% 85.39% +0.01%
==========================================
Files 13 13
Lines 1177 1178 +1
==========================================
+ Hits 1005 1006 +1
Misses 172 172 ☔ View full report in Codecov by Sentry. |
|
Fixed the problem for me. Thanks! |
kecnry
approved these changes
Feb 5, 2025
|
|
||
| Fits an 1D Gaussian profile to spectrum in `img`. Takes the weighted mean |
There was a problem hiding this comment.
Suggested change
| Fits an 1D Gaussian profile to spectrum in `img`. Takes the weighted mean | |
| Fits a 1D Gaussian profile to spectrum in `img`. Takes the weighted mean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #240, where Horne extraction would crash if the 2D spectrum contained an all-nan column.