Skip to content

Commit

Permalink
Apply suggestions from review; link to stable astropy+gwcs docs
Browse files Browse the repository at this point in the history
Co-authored-by: Kelle Cruz <[email protected]>
  • Loading branch information
dhomeier and kelle committed Aug 2, 2024
1 parent 5d057de commit 52dd41f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ jobs:
python: '3.12'
toxenv: py312-test

- name: Python 3.12 (MacOS X)
os: macos-latest
python: '3.12'
toxenv: py312-test

- name: Python 3.10
os: ubuntu-latest
python: '3.10'
Expand Down Expand Up @@ -114,6 +109,12 @@ jobs:
toxenv: py312-test-devdeps
toxposargs: --remote-data=any

# doctest failure due to different no. of significant digits on arm64 (#1146)
- name: Python 3.12 (macOS)
os: macos-latest
python: '3.12'
toxenv: py312-test

steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
# check_sphinx_version("1.2.1")

# Include other packages to link against
intersphinx_mapping['astropy'] = ('https://docs.astropy.org/en/latest/', None)
intersphinx_mapping['gwcs'] = ('https://gwcs.readthedocs.io/en/latest/', None)
intersphinx_mapping['astropy'] = ('https://docs.astropy.org/en/stable/', None)
intersphinx_mapping['gwcs'] = ('https://gwcs.readthedocs.io/en/stable/', None)
intersphinx_mapping['reproject'] = ('https://reproject.readthedocs.io/en/stable/', None)
intersphinx_mapping['mpl_animators'] = ('https://docs.sunpy.org/projects/mpl-animators/en/stable/', None)

Expand Down
4 changes: 2 additions & 2 deletions docs/spectrum1d.rst
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ For spectra read from files containing header-like attributes like a FITS
:class:`~astropy.io.fits.Header` or :attr:`astropy.table.Table.meta`,
loaders are conventionally storing this in ``Spectrum1D.meta['header']``.

Conversely the two provided FITS writers are saving the contents of any
The two provided FITS writers (``tabular-fits`` and ``wcs1d-fits``) save the contents of
``Spectrum1D.meta['header']`` (which should be an :class:`astropy.io.fits.Header`
or any object like a `dict` that can instantiate one) as the header of the
or any object, like a `dict`, that can instantiate one) as the header of the
:class:`~astropy.io.fits.hdu.PrimaryHDU`.

Including Uncertainties
Expand Down

0 comments on commit 52dd41f

Please sign in to comment.