-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devdeps tests to use more recent python, numpy #1086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 64 64
Lines 4483 4483
=======================================
Hits 3171 3171
Misses 1312 1312 ☔ View full report in Codecov by Sentry. |
Somewhat surprisingly, nothing failed in the new test env. I also decided to update the Windows/MacOS tests to use python 3.11, and made all the older tests uniformly test on Ubuntu. Seems more logical to me this way. |
I am glad to see it is green, though coverage is only 70% package-wide, so YMMV. |
I guess if you are feeling adventurous, you can test more dev packages but out of scope here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This forces the devdeps environment to install dev numpy 2, despite matplotlib dev wanting <2. Also upgrades python in the devdeps environment to 3.12. Closes #1082 and closes #1083. Thanks to @pllim.
I'm sure there will be some test failures here, I'll also clean those up in this PR.