Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devdeps tests to use more recent python, numpy #1086

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Sep 27, 2023

This forces the devdeps environment to install dev numpy 2, despite matplotlib dev wanting <2. Also upgrades python in the devdeps environment to 3.12. Closes #1082 and closes #1083. Thanks to @pllim.

I'm sure there will be some test failures here, I'll also clean those up in this PR.

@rosteen rosteen added this to the v1.x milestone Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (1967512) to head (ab09241).
Report is 51 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          64       64           
  Lines        4483     4483           
=======================================
  Hits         3171     3171           
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Contributor Author

rosteen commented Sep 27, 2023

Somewhat surprisingly, nothing failed in the new test env.

I also decided to update the Windows/MacOS tests to use python 3.11, and made all the older tests uniformly test on Ubuntu. Seems more logical to me this way.

@pllim
Copy link
Member

pllim commented Sep 27, 2023

I am glad to see it is green, though coverage is only 70% package-wide, so YMMV.

@pllim
Copy link
Member

pllim commented Sep 27, 2023

Full Python Version: 
3.12.0rc3 (main, Sep 19 2023, 15:43:21) [GCC 11.4.0]

Package versions: 
Numpy: 2.0.0.dev0+git20230926.5c46c11
Scipy: 1.12.0.dev0+1777.bf77616
Matplotlib: 3.9.0.dev301+gd60de5ed4d
astropy: 6.0.dev728+g0c73d13f6
gwcs: 0.19.0
asdf: 3.0.0.dev613+g9680015
asdf-astropy: 0.4.1.dev62+gb4e1764
stdatamodels: 1.8.2
ndcube: 2.1.3
spectral-cube: 0.6.2

I guess if you are feeling adventurous, you can test more dev packages but out of scope here.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit 27db220 into astropy:main Sep 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Python 3.12 TST: Ensure numpy dev is actually installed in devdeps
2 participants