One more fix to dev docs #1112
Merged
One more fix to dev docs #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed single quotes in order for pip install command to work.
kelle
requested review from
eteq,
rosteen,
nmearl and
keflavich
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 70.74% 70.74%
=======================================
Files 64 64
Lines 4484 4484
=======================================
Hits 3172 3172
Misses 1312 1312 ☔ View full report in Codecov by Sentry. |
pin python version to 3.11
|
That's so strange, I've never needed quotes for the pip install to work. Maybe an OS thing. Either way, I tested and it doesn't break the install for me. Good call on the 3.11 specification, 3.12 seems to still need dev versions of a couple dependencies to work. |
rosteen
approved these changes
Nov 22, 2023
rosteen
pushed a commit
to rosteen/specutils
that referenced
this pull request
Nov 29, 2023
* Update contributing.rst Needed single quotes in order for pip install command to work. * Update contributing.rst pin python version to 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed single quotes in order for pip install command to work.