Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template correlation for spectrum with no uncertainty #1118

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Jan 8, 2024

Fixes #1117.

@rosteen rosteen added bug analysis Spectral analysis/measurement tools labels Jan 8, 2024
@rosteen rosteen added this to the v1.x milestone Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb5bd08) 70.87% compared to head (cae45d0) 70.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   70.87%   70.89%   +0.01%     
==========================================
  Files          64       64              
  Lines        4498     4501       +3     
==========================================
+ Hits         3188     3191       +3     
  Misses       1310     1310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Contributor Author

rosteen commented Jan 16, 2024

I think this should be fairly uncontroversial, so I'm going to merge.

@rosteen rosteen merged commit 4723206 into astropy:main Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Spectral analysis/measurement tools bug
Projects
None yet
1 participant