-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spectrum class name from Spectrum1D to Spectrum #1126
Update spectrum class name from Spectrum1D to Spectrum #1126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.0-dev #1126 +/- ##
============================================
+ Coverage 71.26% 72.72% +1.45%
============================================
Files 64 62 -2
Lines 4542 4487 -55
============================================
+ Hits 3237 3263 +26
+ Misses 1305 1224 -81 ☔ View full report in Codecov by Sentry. |
Looks like the test failure is unrelated, I wonder if that MANGA file was removed or changed url or something... |
This is probably the most important part if anyone reviews:
|
* Rename Spectrum1D to Spectrum * Update name in analysis * Update name in fitting and manipulation * Update name in tests * Update name in io * Update name in io tests * Add changelog entry * Update class name in docs * Update schema ref in spectrum_list asdf * Replace instances of 'spectrum1d' * Properly (I think) version change to asdf schema * Add PR number to changelog entry * Remove unused import * Fix doc example output * Fix failing remote data test * Update url to MANGA data for tests * Fix RSS filename
* Rename Spectrum1D to Spectrum * Update name in analysis * Update name in fitting and manipulation * Update name in tests * Update name in io * Update name in io tests * Add changelog entry * Update class name in docs * Update schema ref in spectrum_list asdf * Replace instances of 'spectrum1d' * Properly (I think) version change to asdf schema * Add PR number to changelog entry * Remove unused import * Fix doc example output * Fix failing remote data test * Update url to MANGA data for tests * Fix RSS filename
Does what it says on the tin - based on the result of #1087.
Spectrum1D
will raise a deprecation warning when initialized for some deprecation period.