Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spectrum class name from Spectrum1D to Spectrum #1126

Merged
merged 17 commits into from
Mar 28, 2024

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Mar 26, 2024

Does what it says on the tin - based on the result of #1087. Spectrum1D will raise a deprecation warning when initialized for some deprecation period.

@rosteen rosteen added the data objects Core data objects like Spectrum1D or SpectralCollection label Mar 26, 2024
@rosteen rosteen added this to the v2.0 milestone Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 72.72%. Comparing base (4041081) to head (40ac61b).
Report is 37 commits behind head on v2.0-dev.

Files Patch % Lines
specutils/io/default_loaders/apogee.py 25.00% 3 Missing ⚠️
specutils/io/default_loaders/sdss.py 25.00% 3 Missing ⚠️
specutils/io/default_loaders/sixdfgs_reader.py 25.00% 3 Missing ⚠️
specutils/spectra/spectrum.py 75.00% 3 Missing ⚠️
specutils/io/default_loaders/aaomega_2df.py 33.33% 2 Missing ⚠️
specutils/io/default_loaders/twodfgrs_reader.py 33.33% 2 Missing ⚠️
specutils/io/default_loaders/wcs_fits.py 71.42% 2 Missing ⚠️
specutils/manipulation/smoothing.py 60.00% 2 Missing ⚠️
specutils/manipulation/utils.py 75.00% 2 Missing ⚠️
specutils/io/default_loaders/dc_common.py 50.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##           v2.0-dev    #1126      +/-   ##
============================================
+ Coverage     71.26%   72.72%   +1.45%     
============================================
  Files            64       62       -2     
  Lines          4542     4487      -55     
============================================
+ Hits           3237     3263      +26     
+ Misses         1305     1224      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Contributor Author

rosteen commented Mar 28, 2024

Looks like the test failure is unrelated, I wonder if that MANGA file was removed or changed url or something...

@rosteen
Copy link
Contributor Author

rosteen commented Mar 28, 2024

This is probably the most important part if anyone reviews:

@deprecated(since="2.0", alternative="Spectrum")
class Spectrum1D(Spectrum):

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)

@rosteen rosteen merged commit bbaa743 into astropy:v2.0-dev Mar 28, 2024
12 checks passed
rosteen added a commit to rosteen/specutils that referenced this pull request Jun 18, 2024
* Rename Spectrum1D to Spectrum

* Update name in analysis

* Update name in fitting and manipulation

* Update name in tests

* Update name in io

* Update name in io tests

* Add changelog entry

* Update class name in docs

* Update schema ref in spectrum_list asdf

* Replace instances of 'spectrum1d'

* Properly (I think) version change to asdf schema

* Add PR number to changelog entry

* Remove unused import

* Fix doc example output

* Fix failing remote data test

* Update url to MANGA data for tests

* Fix RSS filename
rosteen added a commit to rosteen/specutils that referenced this pull request Jan 14, 2025
* Rename Spectrum1D to Spectrum

* Update name in analysis

* Update name in fitting and manipulation

* Update name in tests

* Update name in io

* Update name in io tests

* Add changelog entry

* Update class name in docs

* Update schema ref in spectrum_list asdf

* Replace instances of 'spectrum1d'

* Properly (I think) version change to asdf schema

* Add PR number to changelog entry

* Remove unused import

* Fix doc example output

* Fix failing remote data test

* Update url to MANGA data for tests

* Fix RSS filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data objects Core data objects like Spectrum1D or SpectralCollection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant