Add changelog check to CI #1177
Conversation
|
Don't want to use towncrier while you are at it? 😉 Looks like it works because it is failing because you didn't apply the label. ;D |
|
You might have to clean up the change log or something? See warnings in https://github.com/astropy/specutils/actions/runs/11169575830/job/31050585269?pr=1177 Also, from now on, you would need to also make sure all PRs are milestoned properly to match the change log section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 86.86% 86.86%
=======================================
Files 63 63
Lines 4553 4553
=======================================
Hits 3955 3955
Misses 598 598 ☔ View full report in Codecov by Sentry. |
|
Oh yeah, maybe. @bsipocz added that one, I think. |
|
Everything in the changelog is passing now except for this PR missing an entry. |
There was a problem hiding this comment.
It is funny how the bot is even more strict than me. LGTM and looks like https://github.com/astropy/astroquery/blob/main/.github/workflows/changelog.yml . Thanks!
|
I also have a milestone check if you change your mind about milestones. 😆 |
|
Just gonna leave this here. 😝 https://github.com/astropy/astropy/blob/main/.github/workflows/check_milestone.yml |
|
Thanks for the help/eyes on this! |
You got me in a cold sweat for a moment thinking that I was going senile, but then I checked and it was William adding that functionality :) |
|
Oh ooops! Sorry. I should have checked. I am the one getting senile! |
Closes #1165 . Thanks @pllim for the links 🙂