Replace LevMarLSQFitter with TRFLSQFitter

[pllim]

Related PRs:

• Update documentation to not recommend LevMarLSQFitter as the default fitter astropy#16983
• Remove LevMarLSQFitter photutils#1899
• Use TRFLSQFitter instead of LevMarLSQFitter spacetelescope/jdaviz#3202

TRFLSQFitter also has calc_uncertainties and should respect bounds.

Fix #1172

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (becfe37) to head (329b2b4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1180   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files          63       63           
  Lines        4553     4553           
=======================================
  Hits         3955     3955           
  Misses        598      598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[keflavich]

lgtm. Could you confirm that those numerical changes were caused by switching default fitter?

[pllim]

Could you confirm that those numerical changes were caused by switching default fitter?

How should I do that? That is the only change and then the numbers change. Not sure what else I can do. Hope you can advise. Thanks.

[keflavich]

That's pretty much all I was asking. I don't see any other differences. I would like to know what these changes imply about the absolute accuracy of the two methods, or perhaps about their default tolerances, but that desire shouldn't hold back merging this.

[pllim]

@astrofrog did astropy/astropy#16983 so maybe he can explain. I am just propagating that recommendation downstream. 🙏

[astrofrog]

The differences here seem pretty small considering it is a completely different fitting algorithm. Note that TRFLSQFitter does have calc_uncertainties which you can use to find the uncertainties so it would be interesting to try this to see if the differences are indeed within the uncertainties.

[pllim]

I'll leave that exercise for the future but I am uncertain who will do it. 😏

Thanks, all! Merging.