Use exact domain limits for polynomial wavelength solutions in _read_non_linear_iraf_wcs #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
force-pushed
the
iraf-legendre-domains
branch
from
b5ba865 to
fc395f7
Compare
|
failing tests due to #1197 |
rosteen
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196; as described in #1196 (comment) the domain limits
pmin,pmaxfor constructing the Chebychev or Legendre series were truncated tointinstead of allowing floating-point values as used and written by IRAF.This will change the
spectral_axisread in for such spectra (see tests for comparison to the old behaviour), but labelling as a bug fix as IRAF evidently reproduces this model.