Update data loader to the latest PFS datamodel (as of Nov 2024) #1202
+58
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last 2yrs since the data loader for Subaru-pfsObject is created, significant changes has been made for the datamodel. Although it's still actively developed, I'd like to initiate updating the data loader. Unfortunately, at this moment, the actual pfsObject file is still proprietary, but I would like to share an example file once it's publicly available (openuse operation will start in early 2025). Reference: - PFS datamodel: https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt
|
Related issue: #1201 |
|
Thank you! While this does need a change log in |
|
CI failure about "Fits" deprecation warning is unrelated and can be ignored for now, though that also means you would have to rebase this PR in the future when it is fixed upstream. FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last 2yrs since the data loader for Subaru-pfsObject is created, significant changes has been made for the datamodel. Although it's still actively developed, I'd like to initiate updating the data loader.
Note that I didn't keep the old loader, so no backward compatibility is maintained.
Unfortunately, at this moment, the actual pfsObject file is still proprietary, but I would like to share an example file once it's publicly available (openuse operation will start in early 2025).
The changes also include code formatting by black.
Reference:
Fix #1201