Skip to content

Commit

Permalink
BUG: Fix install in older Python by changing v2 to confv2 (#62)
Browse files Browse the repository at this point in the history
* Use older Python to build wheel

* BUG: Fix install for older Python
by changing v2 to confv2 in extras_require
  • Loading branch information
pllim authored Jun 7, 2023
1 parent 1ca1569 commit 9bfe92f
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.8"

- name: Install build dependencies
run: python -m pip install pip build "twine>=3.3" -U
Expand Down
7 changes: 5 additions & 2 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
Changes in sphinx-astropy
=========================

2.0 (unreleased)
----------------
1.9.1 (2023-06-07)
------------------

- Renamed ``[v2]`` optional dependencies key to ``[confv2]``
to avoid triggering build error in Python 3.10 or earlier. [#63]

1.9 (2023-06-06)
----------------
Expand Down
8 changes: 4 additions & 4 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ Installing **sphinx-astropy** will automatically install (if not already present

* `pytest-doctestplus <https://github.com/astropy/pytest-doctestplus/>`_ - providing the 'doctestplus' extension to skip code snippets in narrative documentation.

pydata-sphinx-theme (v2)
^^^^^^^^^^^^^^^^^^^^^^^^
pydata-sphinx-theme (confv2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

To use the new `pydata-sphinx-theme` with `sphinx_astropy.conf.v2`, you have to install
the optional `[v2]` dependencies::
the optional `[confv2]` dependencies::

pip install sphinx-astropy[v2]
pip install sphinx-astropy[confv2]

That would pull in the following as well:

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ install_requires =
pytest-doctestplus>=0.11

[options.extras_require]
v2 =
confv2 =
pydata-sphinx-theme
sphinx-copybutton
all = astropy
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ changedir = .tmp/{envname}
description = run tests
extras =
tests
v2deps: v2
v2deps: confv2
deps =
sphinx30: sphinx==3.0.*
sphinx30: docutils==0.17.*
Expand Down

0 comments on commit 9bfe92f

Please sign in to comment.