Address final reviews

Signed-off-by: P Aswini Kumar <[email protected]>
aswiniip · Sep 30, 2024 · 42c3ad8 · 42c3ad8
1 parent c356c89
commit 42c3ad8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/contrib/babelfishpg_tsql/src/multidb.c b/contrib/babelfishpg_tsql/src/multidb.c
@@ -1342,6 +1342,8 @@ get_physical_user_name(char *db_name, char *user_name, bool suppress_db_error, b
 						errmsg("User or role \"%s\" does not exist", new_user_name)));
 	}
 
+	pfree(new_user_name);
+
 	return result;
 }
 

diff --git a/contrib/babelfishpg_tsql/src/procedures.c b/contrib/babelfishpg_tsql/src/procedures.c
@@ -2137,6 +2137,7 @@ sp_addrole(PG_FUNCTION_ARGS)
 		/* Map the logical role name to its physical name in the database. */
 		physical_role_name = get_physical_user_name(get_cur_db_name(), lowercase_rolname, false, true);
 		role_oid = get_role_oid(physical_role_name, true);
+		pfree(physical_role_name);
 
 		/* Check if the user, group or role already exists */
 		if (role_oid)
@@ -2193,7 +2194,6 @@ sp_addrole(PG_FUNCTION_ARGS)
 	set_config_option("babelfishpg_tsql.sql_dialect", saved_dialect,
 					  GUC_CONTEXT_CONFIG,
 					  PGC_S_SESSION, GUC_ACTION_SAVE, true, 0, false);
-	pfree(physical_role_name);
 	PG_RETURN_VOID();
 }
 
@@ -2281,6 +2281,7 @@ sp_droprole(PG_FUNCTION_ARGS)
 		/* Map the logical role name to its physical name in the database. */
 		physical_role_name = get_physical_user_name(get_cur_db_name(), lowercase_rolname, false, true);
 		role_oid = get_role_oid(physical_role_name, true);
+		pfree(physical_role_name);
 
 		/* Check if the role does not exists */
 		if (role_oid == InvalidOid || !is_role(role_oid))
@@ -2332,7 +2333,6 @@ sp_droprole(PG_FUNCTION_ARGS)
 	set_config_option("babelfishpg_tsql.sql_dialect", saved_dialect,
 					  GUC_CONTEXT_CONFIG,
 					  PGC_S_SESSION, GUC_ACTION_SAVE, true, 0, false);
-	pfree(physical_role_name);
 	PG_RETURN_VOID();
 }
 

diff --git a/contrib/babelfishpg_tsql/src/rolecmds.c b/contrib/babelfishpg_tsql/src/rolecmds.c
@@ -846,7 +846,7 @@ user_id(PG_FUNCTION_ARGS)
     }
 
     auth_tuple = SearchSysCache1(AUTHNAME, CStringGetDatum(user_name));
-	pfree(user_name);
+    pfree(user_name);
 
     if (!HeapTupleIsValid(auth_tuple))
 	    PG_RETURN_NULL();