Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 Adding CoreferenceProcessor #41

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
880329f
add empty coref processor
KiaLAN Jun 15, 2022
d9b3f71
add process method. TODO: correct span
KiaLAN Jun 15, 2022
da36372
fix output span
KiaLAN Jun 16, 2022
6dafabe
add more default configs and comment
KiaLAN Jun 16, 2022
0e18a8f
change nlp pipeline
KiaLAN Jun 17, 2022
2d28246
Merge branch 'master' of https://github.com/asyml/ForteHealth into 15…
KiaLAN Jun 17, 2022
fcafb22
add more entries to MedicalArticle; add comment
KiaLAN Jun 17, 2022
0b675aa
fixed some comments
KiaLAN Jun 17, 2022
d0812ee
fix comments and format files
KiaLAN Jun 17, 2022
0769453
update requirements.txt
KiaLAN Jun 17, 2022
5a55b41
update setup.py
KiaLAN Jun 17, 2022
fdc343e
add unit test
KiaLAN Jun 17, 2022
85bf9bb
remove duplicated definition
KiaLAN Jun 17, 2022
9579923
fix ddt
KiaLAN Jun 17, 2022
4e41b34
fix import
KiaLAN Jun 17, 2022
443f886
formatting
KiaLAN Jun 17, 2022
5f3cf34
remove long lines
KiaLAN Jun 17, 2022
a11f209
remove unused import
KiaLAN Jun 17, 2022
07dbb02
add cython to dependency
KiaLAN Jun 17, 2022
008eb1b
delay the installation of neuralcoref
KiaLAN Jun 17, 2022
ce2fd6f
put installation of neuralcoref in workflow
KiaLAN Jun 17, 2022
e832289
fix typo
KiaLAN Jun 17, 2022
c18f704
skip mypy's None is not callable bug
KiaLAN Jun 17, 2022
a9cf38d
black format
KiaLAN Jun 17, 2022
2c346fb
add spacy
KiaLAN Jun 17, 2022
037f33b
add cython and pytest
KiaLAN Jun 17, 2022
5856d15
remove commented code
KiaLAN Jun 17, 2022
03b6d69
fix unit test data
KiaLAN Jun 17, 2022
9e55211
fix unit test data 2
KiaLAN Jun 17, 2022
2730b88
remove the dependency of SpacyProcessor
KiaLAN Jun 17, 2022
5f6d024
update unit test
KiaLAN Jun 17, 2022
c9d56a4
remove TODO
KiaLAN Jun 17, 2022
09114ad
add load_lang_model
KiaLAN Jun 17, 2022
cb676c3
remove spacy from requirements and setup
KiaLAN Jun 17, 2022
e5ef675
change import order
KiaLAN Jun 17, 2022
8b18e67
use ddt data and unpack
KiaLAN Jul 1, 2022
299d6d3
update config structure
KiaLAN Jul 1, 2022
1a0e239
add comment for lang
KiaLAN Jul 1, 2022
36bcaba
fix set() bug
KiaLAN Jul 1, 2022
3a20b8d
add offset calculation assertion
KiaLAN Jul 1, 2022
26efabd
formatting
KiaLAN Jul 1, 2022
f7db024
udpate test
KiaLAN Jul 1, 2022
f453e60
shorten comment
KiaLAN Jul 1, 2022
1d006fd
remove store_scores
KiaLAN Jul 1, 2022
dcec89f
fix assertion
KiaLAN Jul 1, 2022
465341d
remove store_scores in test
KiaLAN Jul 1, 2022
3ee2f7b
rename document to entry
KiaLAN Jul 1, 2022
1d44ff7
fix cfg_inference kwargs
KiaLAN Jul 1, 2022
0ad95d8
add conv_dict test
KiaLAN Jul 1, 2022
87b0996
black reformat
KiaLAN Jul 1, 2022
148e918
fix pylint
KiaLAN Jul 1, 2022
2fefe18
update comment
KiaLAN Jul 1, 2022
662b324
update comment
KiaLAN Jul 1, 2022
6bcc58c
try one
KiaLAN Jul 9, 2022
ae31363
use subprocess to install cython
KiaLAN Jul 9, 2022
74ffad4
use subprocess to install cython and spacy
KiaLAN Jul 9, 2022
f3dc9e3
add extras_require for icd and coref
KiaLAN Jul 9, 2022
2581edb
remove spacy and neuralcoref stage from main.yml
KiaLAN Jul 9, 2022
e09dfe7
replace load_module with get_class
KiaLAN Jul 9, 2022
c925f5b
remove 'model' argument
KiaLAN Jul 9, 2022
f6c1a8b
fix rebundunt import and args
KiaLAN Jul 9, 2022
035a2c8
fix merge conflict
KiaLAN Jul 16, 2022
7b31beb
fix merge conflict
KiaLAN Jul 16, 2022
5ef774a
fix merge conflict
KiaLAN Jul 16, 2022
ffe88f6
fix merge conflict: restore coref test
KiaLAN Jul 16, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
put installation of neuralcoref in workflow
  • Loading branch information
KiaLAN committed Jun 17, 2022
commit ce2fd6f23d5b7b7c982f47c422b08b519a1459b0
4 changes: 4 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -89,6 +89,10 @@ jobs:
cd forte-wrappers
pip install src/spacy

- name: Install NeuralCoref
KiaLAN marked this conversation as resolved.
Show resolved Hide resolved
run: |
git install git+https://[email protected]/huggingface/[email protected]#egg=neuralcoref

- name: Test with pytest and run coverage
run: |
coverage run -m pytest tests/