-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NegationContextAnalyzer processor and unit tests #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I guess we want to lint the project with
mypy
,pylint
andblack
to make it more standard before we merge this. - We will also need to set up test cases (and write test cases), like here.
Sure. I'll update the workflow with more linting tools. |
@hunterhector Still unable to add @tanyuqian as a reviewer. It says I can add atmost 1 reviewer. |
Add bowen in the future. I will get notified for the PRs anyway |
Pytest and documentation has been updated. |
@tanyuqian I had already added test cases for |
@Piyush13y Could you double-check it is working from your end? like re-install forte/forte-wrapper/forte-medical and re-run? I got the same error message as the workflow here https://github.com/asyml/forte-medical/runs/5435388860?check_suite_focus=true#step:13:23 |
@tanyuqian There were 2 issues raised in the CI pipeline initially, one was due to a stray test folder which, on deletion, fixed that problem. |
This PR fixes #3
Description of changes
NegationContextAnalyzer
processor addedNegationContextAnalyzer
to the pipelinePossible influences of this PR.
Demo pipeline now uses the new processor and detects negation contexts for entity mentions.
Expected Output