Ftx namespace changes to processors #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterhector
reviewed
Mar 1, 2022
|
Sounds good, let’s address this in another. We can merge this after we fix
the mypy runs tomorrow
On Tue, Mar 1, 2022 at 10:02 PM Piyush Yadav ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/spacy/fortex/spacy/spacy_processors.py
<#89 (comment)>:
> @@ -28,7 +28,7 @@
from forte.data.ontology import Annotation
from forte.processors.base import PackProcessor, FixedSizeBatchProcessor
from ft.onto.base_ontology import EntityMention, Sentence, Token, Dependency
-from ftx.medical.clinical import MedicalEntityMention, UMLSConceptLink
+from ftx.onto.clinical import MedicalEntityMention, UMLSConceptLink
Got it, I was looking at pretrained_encoder_processor.py but this example
is a better one since we will need to set attributes of the class instances.
I will be making changes to SpacyProcessor pertaining to this, since we
will need to pass both MedicalEntityMention and UMLSConceptLink through
config. I am thinking we should have a new issue (which better explains the
problem) and PR for this? This particular PR can be pushed as is.
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYBNZ2BCCRNMLXGKW54CLU53K2TANCNFSM5PDLKLOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
Hector, Liu Zhengzhong
Website: https://hunterhector.github.io/
LinkedIn: http://www.linkedin.com/pub/hector-zhengzhong-liu/23/115/406
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #87
Description of changes
With reference to changes merged through Forte in PR, we updated the ontology namespace structure. The processors in Forte-wrapper needed to incorporate those updated namespaces. Only
SpacyProcessorworks with theftxfolder, hence that's the only file that has been updated.Possible influences of this PR.
Code shouldn't throw Import errors now.