Numpy typing fix #94
Merged
Numpy typing fix #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yping is missing in earlier numpy version
|
so there are multiple convoluting bugs. Some errors in this PR should be fixed by another. #89. But the initial mypy checks has passed. So I will probably force merge this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #91.
Description of changes
Make sure numpy typing is compatible with numpy==1.21
Possible influences of this PR.
Typing names are no longer compatible with numpy==1.19 but linting with mypy in CI test only checks typing under numpy==1.21.
Test Conducted
Describe what test cases are included for the PR.