Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout improve #76

Merged
merged 2 commits into from
Jun 16, 2020
Merged

layout improve #76

merged 2 commits into from
Jun 16, 2020

Conversation

GingerBear
Copy link
Collaborator

@GingerBear GingerBear requested a review from hunterhector June 16, 2020 17:58
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems in the previous issues are fixed. But it looks like there are two residual problems

  1. Selecting one of the legends seems to add too many new lines. See the comparison of the following two screenshots. After selecting the WikiSection legend, there is several more new lines before "See also"

Screen Shot 2020-06-16 at 2 18 45 PM


Screen Shot 2020-06-16 at 2 18 55 PM


  1. If we narrow the browser window a bit more, somehow the calculation of the annotation is off again (smaller than the actual text length).

Screen Shot 2020-06-16 at 2 19 16 PM

@GingerBear
Copy link
Collaborator Author

fixed the second issue. For the first issue, the extra space was kept for display lines and text label, it's not smart enough to further adjust by the context when those doesn't exist. Let's keep that for another time to fix.

@hunterhector
Copy link
Member

hunterhector commented Jun 16, 2020

fixed the second issue.

Just tested it, looks OK now.

For the first issue, the extra space was kept for display lines and text label, it's not smart enough to further adjust by the context when those doesn't exist. Let's keep that for another time to fix.

Yeah. Let me create another issue for this.

@GingerBear
Copy link
Collaborator Author

this is a good example for that we need more examples to make the tools better

@GingerBear
Copy link
Collaborator Author

Yeah. Let me create another issue for this.

already created at #77

@hunterhector
Copy link
Member

Yeah. Let me create another issue for this.

already created at #77

Thanks. I think this PR looks good, will merge it.

Btw, I will also create an Issue template to help other people understand thee.

@hunterhector hunterhector merged commit 454c224 into master Jun 16, 2020
@hunterhector hunterhector deleted the dev branch November 8, 2020 14:43
hunterhector added a commit that referenced this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional annotation highlight missmatching.
2 participants