-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Loop::getHandle #121
Add Loop::getHandle #121
Conversation
Previously we advised to use Loop::get()->getHandle(), because it's a method only required by very few components, namely the filesystem libraries, which need the underlying handle to operate. We argued that we get a smaller autocomplete list that way. I think consistency is more important.
I still feels like it clutters the API that application writers would need to use. Only libs should be concerned about the specific loop implementation being used. |
I agree with @trowski — the autocomplete list is not important. It's about people looking at the Loop class and finding (for them) irrelevant functions. |
I'll close this one for now, we can always add it in a |
It won't if |
We said |
To me, the important thing is to be able to make changes which are breaking for loop implementors (e.g. add a method to I think the value is less in separating Loop/Driver and more in separating API & SPI. |
Previously we advised to use Loop::get()->getHandle(), because it's a method only required by very few components, namely the filesystem libraries, which need the underlying handle to operate.
We argued that we get a smaller autocomplete list that way. I think consistency is more important.