docs: add spectral ruleset docs #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
fmvilas,
magicmatatjahu,
derberg,
smoya and
asyncapi-bot-eve
as code owners
|
Gonna close #698 after this is merged. |
|
@smoya can you have a look? 🙂 |
|
Yeah @smoya cause I have no idea 😅 |
Gonna add to my todo list 😅 omg parental leave |
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
Co-authored-by: Sergio Moya <[email protected]>
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
reviewed
Jun 28, 2023
smoya
requested changes
Jun 28, 2023
Co-authored-by: Sergio Moya <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
smoya
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
LGTM! 🚀🌔
Thanks @magicmatatjahu and @jonaslagoni for bringing this 🙌
|
Thanks for the review @smoya 💪 |
|
🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuum of @magicmatatjahu PR in #700
Related issue(s)
Fixes #698