fix: use JSON Pointer last element as ID for reply.channel and reply.messages[] #895
Conversation
| it('Reply channel + messages[] Ids come from JSON Pointer', async function() { | ||
| const parser = new Parser(); | ||
|
|
||
| const documentRaw = `{ |
There was a problem hiding this comment.
This doc is the one @AceTheCreator shared in #873.
We could remove it or adapt it, but we need something to test this anyway.
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
Fixes #873
This PR puts on practice one of the solutions we might opt in for getting Id's on referenced objects via the last element of their JSON Pointer. In this case, we are doing this for the
reply.channelandreply.messages[], since in the Operation Reply those are referenced via a JSON Pointer.I'm also fixing a bug where
reply.messageswere expected to be a map instead of an array.Related issue(s)
Fixes #873