Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow to support release branches #255

Closed
wants to merge 1 commit into from

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Sep 20, 2022

when we changed release branches, we forgot to update the workflow that reacts to them, we forgot to change the names of branches in the config

Refs asyncapi/spec#834

@char0n
Copy link
Collaborator Author

char0n commented Sep 20, 2022

@fmvilas @dalelane @derberg please have a look at this PR. Exactly the same issue as in asyncapi/spec#834

@char0n char0n mentioned this pull request Sep 20, 2022
61 tasks
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n
Copy link
Collaborator Author

char0n commented Sep 20, 2022

Superseded by asyncapi/.github#180

@char0n char0n closed this Sep 20, 2022
@derberg
Copy link
Member

derberg commented Sep 21, 2022

keep in mind that in release branch workflow is still outdated https://github.com/asyncapi/spec-json-schemas/blob/next-spec/.github/workflows/if-nodejs-release.yml

You need to do 👇🏼 from asyncapi/spec#830
Screenshot 2022-09-21 at 15 57 33

Otherwise there will be no automated updates to next-spec from master branch done by bot

@char0n
Copy link
Collaborator Author

char0n commented Sep 22, 2022

PR sent: #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants