Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update asyncapi document definition #1003

Conversation

quetzalliwrites
Copy link
Member

@quetzalliwrites quetzalliwrites commented Dec 12, 2023

The original spec text seems to inaccurately suggest that multiple AsyncAPI documents are required for each application, whereas the correct statement would be that a single AsyncAPI document, potentially referencing other files, is typically used to describe an application's API.

Perhaps it is more accurate to say that the AsyncAPI Specification defines a set of fields that can be used in one or more AsyncAPI documents to describe an application's API. A single AsyncAPI document can reference other files, but it doesn't mean that multiple AsyncAPI documents are required for a single application.

While the AsyncAPI document is the primary file describing the API, it can include references to other files that contain additional details or shared fields. This doesn't equate to requiring multiple AsyncAPI documents for a single application.

related to https://github.com/asyncapi/website/pull/1868/files#r1424279213

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas @smoya @dalelane @char0n hey folks, please have a look, especially related discussion, to make sure we are all aligned

spec/asyncapi.md Outdated Show resolved Hide resolved
spec/asyncapi.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @alequetzalli! This looks far more accurate now.

@quetzalliwrites
Copy link
Member Author

Nice catch @alequetzalli! This looks far more accurate now.

@smoya well thank youuuuu 😎

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

week passed, no more comments, merging

Thanks @alequetzalli !

@derberg
Copy link
Member

derberg commented Dec 19, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit dfdb768 into asyncapi:master Dec 19, 2023
7 of 8 checks passed
@smoya
Copy link
Member

smoya commented Feb 8, 2024

@all-contributors please add @alequetzalli for content,doc,example,ideas,review

Copy link
Contributor

@smoya

I've put up a pull request to add @alequetzalli! 🎉

@smoya
Copy link
Member

smoya commented Feb 8, 2024

@all-contributors please add @alequetzalli for content,doc,example,ideas,review

Copy link
Contributor

@smoya

I've put up a pull request to add @alequetzalli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants