Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade GH workflows and fix markdown linting #958

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Aug 2, 2023

fixes: #940

additionally:

@derberg
Copy link
Member Author

derberg commented Aug 2, 2023

ok, new linter workflow works, and fails if error simulated (I made changes in config) https://github.com/asyncapi/spec/actions/runs/5739972585/job/15556776030?pr=958

@derberg
Copy link
Member Author

derberg commented Aug 2, 2023

@jonaslagoni how is this affecting 3.0 work? I guess the problem might be with the asyncapi.md document only, right?

@jonaslagoni
Copy link
Member

@derberg the problems it highlight, is not really problems when rendered in the website is it? 🤨

@derberg
Copy link
Member Author

derberg commented Aug 2, 2023

@jonaslagoni you mean headings and whitespaces?

  • whitespaces dunno, but it was easy as autofixed with --fix flag
  • headings -> is was actually strange the h difference that causes such strange indent in TOC
    Screenshot 2023-08-02 at 16 24 50

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni
Copy link
Member

@derberg once this is merged I would assume we can discard any of the asyncapi.md changes and just run the same markdown lint again and commit that, right?

@jonaslagoni
Copy link
Member

So a manual merge commit is needed for sure yea

@smoya
Copy link
Member

smoya commented Aug 11, 2023

Can we proceed merging this? cc @derberg @jonaslagoni Is anything else missing?

@jonaslagoni
Copy link
Member

@smoya yep, just need your review 😄

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented Aug 11, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 121ea2b into asyncapi:master Aug 11, 2023
9 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for urgent changes in GitHub Actions automation
4 participants