Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #987

Closed
wants to merge 1 commit into from

Conversation

PrakharSachan5342
Copy link

Removing Platinum sponsors section as it is outdated and we maintain up to date list in most popular repo -> https://github.com/asyncapi/spec

Have successfully removed platinum sponsors

If you want any other changes i could help doing it

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "Update README.md". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Author

@PrakharSachan5342 PrakharSachan5342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed Platinum sponsors from readme as it is outdated

@char0n
Copy link
Collaborator

char0n commented Nov 10, 2023

@derberg is this something that we want to do?

@PrakharSachan5342
Copy link
Author

@derberg is this something that we want to do?

yes @derberg told to remove the platinum sponsors list as it is out dated , pls accept my pr

@dalelane
Copy link
Collaborator

@PrakharSachan5342 I think perhaps you misunderstood the comment

The suggestion was to remove the platinum sponsors section from https://github.com/asyncapi/community/blob/master/README.md because there was an up to date version in this repo's README. The suggestion was not to remove the up to date version in this repo's README.

@derberg
Copy link
Member

derberg commented Nov 13, 2023

@PrakharSachan5342 I think perhaps you misunderstood asyncapi/community#927 (comment)
The suggestion was to remove the platinum sponsors section from https://github.com/asyncapi/community/blob/master/README.md because there was an up to date version in this repo's README. The suggestion was not to remove the up to date version in this repo's README.

💯 what @dalelane wrote
@PrakharSachan5342 you opened a PR in a wrong repo. Here we maintain up to date list. Closing this one

@derberg derberg closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants