Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roadmap modal overlay fix #1919

Closed
wants to merge 3 commits into from

Conversation

vishvamsinh28
Copy link
Contributor

@vishvamsinh28 vishvamsinh28 commented Jul 8, 2023

This pull request fixes overlay issue of roadmap modal for both larger and smaller devices

Output on different screen sizes :-

Screenshot 2023-07-09 at 1 41 25 AM~2

Screenshot 2023-07-09 at 1 41 00 AM~2

Screenshot 2023-07-09 at 1 41 11 AM

Screenshot 2023-07-09 at 1 41 35 AM~2

Fixes #1906

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify
Copy link

netlify bot commented Jul 8, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d599b82
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64ad080f7942c00008f58003
😎 Deploy Preview https://deploy-preview-1919--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1919--asyncapi-website.netlify.app/

@derberg
Copy link
Member

derberg commented Jul 12, 2023

@vishvamsinh28 sorry mate but I closing it in favour of #1918 as the priority here have people that report issue, if they create PR, their PR is first to take and I see the contributor continues the work. Feel free to jump in there and help with review.

Don't feel discouraged by the fact that I close your PR but please take it as a lesson. Open source is not about speed and who first creates a PR but more about collaboration and community. So if you want to take up some task, first clarify nobody else is working on it

@derberg derberg closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay bug in the /roadmap
2 participants