Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved styling for annoucement hero #1921

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

vishvamsinh28
Copy link
Contributor

@vishvamsinh28 vishvamsinh28 commented Jul 9, 2023

This pull request improves the styling of annoucement banner for smaller devices

Before :-

Screenshot 2023-07-09 at 10 42 52 AM

After :-

Screenshot 2023-07-09 at 10 39 57 AM

Fixes #1920

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 2932896
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64ad6bbe0336d10008730b52
😎 Deploy Preview https://deploy-preview-1921--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1921--asyncapi-website.netlify.app/

@vishvamsinh28 vishvamsinh28 changed the title fix: Improved styling for annoucement hero fix: improved styling for annoucement hero Jul 9, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please next time also specify link to the page where you saw an issue.

first I was checking landing page and was confused as there was no error, took me some time to figure from the screen shots.

thanks for the fix!

@derberg
Copy link
Member

derberg commented Jul 11, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 9c6ce28 into asyncapi:master Jul 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve styling of campaigns (AnnoucementHero)
3 participants