Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the NYC code coverage #2354

Closed
wants to merge 7 commits into from
Closed

feat: add the NYC code coverage #2354

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a3baa4
feat: add the NYC code coverage
sambhavgupta0705 Nov 28, 2023
de1a1b9
Merge branch 'master' into nyc_code_coverage
sambhavgupta0705 Nov 28, 2023
cc042a2
Merge branch 'master' into nyc_code_coverage
akshatnema Dec 3, 2023
099ea83
Merge branch 'master' into nyc_code_coverage
akshatnema Dec 5, 2023
6a92d17
fix package-lock.json
akshatnema Dec 5, 2023
1c7eb13
Merge branch 'master' into nyc_code_coverage
sambhavgupta0705 Dec 14, 2023
bbaccc2
Merge branch 'master' into nyc_code_coverage
sambhavgupta0705 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/code_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Code Coverage Report

on:
pull_request:
branches:
- code_coverage_setup

jobs:
code-coverage:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Install dependencies
run: npm install

- name: Instrumentation
run: npx nyc instrument ./ instrumented

- name: Move folder
run: mv config instrumented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use cp command instead of mv. Also, move the entire folder using the command:

cp -r config instrumented/config


- name: Run tests with coverage
run: npm run test:coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of running the separate command/workflow for test coverage, can't we merge it with cypress-tests.yml workflow?


- name: Comment coverage
if: always()
uses: Tintef/[email protected]
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SKIP_COVERAGE_FOLDER: 'true'
Loading
Loading